fix which repairs set_line_geodata if the net doesn't have geodata fo… #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2123 +/- ##
============================================
+ Coverage 62.30% 79.44% +17.14%
============================================
Files 255 255
Lines 28062 27951 -111
============================================
+ Hits 17483 22205 +4722
+ Misses 10579 5746 -4833 ☔ View full report in Codecov by Sentry. |
|
please add a changelog mention |
rbolgaryn
previously requested changes
Sep 14, 2023
ignore_zero_length lead to assignment error in set_line_geodata_from_bus_geodata.
Feature/repaired set line geodata
SteffenMeinecke
approved these changes
Nov 29, 2023
SteffenMeinecke
previously approved these changes
Nov 29, 2023
SteffenMeinecke
dismissed
rbolgaryn’s stale review
the changelog has been adapted
|
tutorial tests are failing:
Can it have anything to do with the changes in this PR? |
…eature/repaired_set_line_geodata AND plotting_toolbox revision and testing
|
@vogt31337 @KS-HTK I fixed this PR. Can you please merge? |
KS-HTK
requested changes
Jun 4, 2024
…eature/repaired_set_line_geodata
…m/vogt31337/pandapower into feature/repaired_set_line_geodata
KS-HTK
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
currently if you have a somewhat broken grid, which doesn't have geodata for all lines, you can take this function and "create" line data from the connecting nodes. But if not all nodes are having geodata, this function breaks.
This fix will now calculate a mean replacement coordinate (if the user wants it) and sets this replacement into all nodes without geodata. Therefore the grid will have many lines connecting to the center, but It's better than nothing...
BR